✨Simultaneous access: allow access to collaborative services #8236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderegg
added
the
a:webserver
sanderegg
force-pushed
the
i1975/unlock-collaborative-nodes
branch
from
039d59e to
e7414dd
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #8236 +/- ##
==========================================
+ Coverage 87.98% 89.83% +1.85%
==========================================
Files 1917 1508 -409
Lines 74166 62297 -11869
Branches 1301 498 -803
==========================================
- Hits 65253 55966 -9287
+ Misses 8521 6202 -2319
+ Partials 392 129 -263
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Contributor
🧪 CI InsightsHere's what we observed from your CI run for a18226e. ✅ Passed Jobs With Interesting Signals
|
sanderegg
force-pushed
the
i1975/unlock-collaborative-nodes
branch
4 times, most recently
from
310885c to
dd622da
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements collaborative access for dynamic services by allowing multiple users to simultaneously access services that support collaboration (currently only jupyter-math 3.1.0). The changes primarily focus on modifying the node locking logic to check if a service is collaborative before applying locks, and include various code formatting improvements.
Key changes:
- Modified node sharing logic to allow access to collaborative services
- Added
is_collaborativefield to track service collaboration capability - Applied code style improvements across multiple files
Reviewed Changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
services/web/server/src/simcore_service_webserver/projects/_projects_service.py |
Updated node share state logic to check collaborative status and formatting improvements |
services/web/server/src/simcore_service_webserver/projects/_crud_api_read.py |
Function call formatting improvement |
services/web/server/src/simcore_service_webserver/projects/_crud_api_create.py |
Function call formatting improvement |
services/web/server/src/simcore_service_webserver/projects/_controller/projects_states_rest.py |
Function call formatting improvement |
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/scheduler/_core/_scheduler_utils.py |
Added is_collaborative field to model creation |
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/sidecar.py |
Assert statement formatting improvement |
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_service_specs/proxy.py |
Assert statement formatting improvement |
services/director-v2/src/simcore_service_director_v2/modules/dynamic_sidecar/docker_compose_specs.py |
Variable assignment and function call formatting improvements |
services/autoscaling/tests/unit/test_modules_cluster_scaling_dynamic.py |
Multiple assert statement formatting improvements |
services/autoscaling/tests/unit/conftest.py |
Multiple assert statement formatting improvements |
packages/models-library/tests/test_docker.py |
Assert statement formatting improvement |
packages/models-library/src/models_library/api_schemas_directorv2/dynamic_services_service.py |
Added is_collaborative field definition to RunningDynamicServiceDetails |
services/web/server/src/simcore_service_webserver/projects/_projects_service.py
Outdated
Show resolved
Hide resolved
sanderegg
requested review from
GitHK,
giancarloromeo,
matusdrobuliak66 and
pcrespov
as code owners
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
GitHK
reviewed
Aug 22, 2025
Contributor
GitHK
left a comment
GitHK
left a comment
There was a problem hiding this comment.
I guess ooil does not complain when you have added this new field.
packages/models-library/src/models_library/api_schemas_directorv2/dynamic_services_service.py
Show resolved
Hide resolved
sanderegg
force-pushed
the
i1975/unlock-collaborative-nodes
branch
from
aa154a9 to
a18226e
Compare
Member
Author
|
@mergify queue |
Contributor
🟠 Waiting for conditions to match
|
|
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
Collaborative services can be opened by multiple users (e.g. currently only jupyter-math 3.1.0)
the locked state of the NodeUpdate event will be set accordingly.
Related issue/s
How to test
Dev-ops